Reload config and read once and services #83
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avara1986
commented
Jan 21, 2020
| def reload_conf(self): | ||
| self.delete_services() | ||
| self.config.reload() | ||
| self.init_services() |
There was a problem hiding this comment.
@miguelgrubin an other aproach, we reload config but no restart services and app, @alexppg view that, if we restart the config we must restart the DDBB and other libs
There was a problem hiding this comment.
Yeah, it would be awesome to be able to add to this "restart" feature an abstract way to restart anything. This way, pyms wouldn't need to support every feature ever used but the developer could use it as a function, handler or something like that. @avara1986 @miguelgrubin
miguelgrubin
approved these changes
Jan 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.