Skip to content

Human readable config errors #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 16, 2020
Merged

Conversation

avara1986
Copy link
Member

Show more help information if the config file not have a good structure with error messages like

Config file must start with `pyms` keyword, for example:
    pyms:
      services:
        metrics: true
        requests:
          data: data
        swagger:
          path: ""
          file: "swagger.yaml"
        tracer:
          client: "jaeger"
          host: "localhost"
          component_name: "Python Microservice"
      config:
        DEBUG: true
        TESTING: true

@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 99.71% when pulling 2ca9652 on feature/human_readable_config_errors into e70f4be on master.

@alexppg
Copy link
Member

alexppg commented Feb 16, 2020

LGTM, this sure will be helpful.

@avara1986 avara1986 added the Improvement Not a bug but... could be better label Feb 16, 2020
@avara1986 avara1986 merged commit 824cb5c into master Feb 16, 2020
@avara1986 avara1986 deleted the feature/human_readable_config_errors branch February 16, 2020 20:57
@avara1986
Copy link
Member Author

@alvarolinarescabre suggested this change 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Improvement Not a bug but... could be better
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants