Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request response binary format support #710

Merged
merged 2 commits into from
Nov 1, 2023

Conversation

p1c2u
Copy link
Collaborator

@p1c2u p1c2u commented Oct 31, 2023

Backward incompatibilities

  • body of Request protocol returns bytes instead of str
  • data of Response protocol returns bytes instead of str

@p1c2u p1c2u force-pushed the feature/request-response-binary-format-support branch 2 times, most recently from 87cb61a to 0cf49c0 Compare October 31, 2023 17:49
@p1c2u p1c2u changed the title Request binary format support Request response binary format support Oct 31, 2023
@p1c2u p1c2u force-pushed the feature/request-response-binary-format-support branch from 0cf49c0 to a1e0d88 Compare October 31, 2023 17:56
Copy link

codecov bot commented Oct 31, 2023

Codecov Report

Merging #710 (10fdbea) into master (16e7b1a) will increase coverage by 0.00%.
The diff coverage is 89.15%.

@@           Coverage Diff           @@
##           master     #710   +/-   ##
=======================================
  Coverage   91.01%   91.02%           
=======================================
  Files         127      127           
  Lines        3986     4011   +25     
  Branches      488      492    +4     
=======================================
+ Hits         3628     3651   +23     
- Misses        294      295    +1     
- Partials       64       65    +1     
Files Coverage Δ
openapi_core/contrib/aiohttp/requests.py 93.54% <100.00%> (ø)
openapi_core/contrib/django/requests.py 95.83% <100.00%> (ø)
openapi_core/contrib/django/responses.py 100.00% <100.00%> (ø)
openapi_core/contrib/falcon/responses.py 93.75% <100.00%> (+1.44%) ⬆️
openapi_core/contrib/requests/responses.py 100.00% <100.00%> (ø)
openapi_core/contrib/werkzeug/requests.py 93.54% <100.00%> (ø)
openapi_core/contrib/werkzeug/responses.py 100.00% <100.00%> (ø)
...penapi_core/deserializing/media_types/datatypes.py 100.00% <100.00%> (ø)
...pi_core/deserializing/media_types/deserializers.py 86.36% <100.00%> (-0.16%) ⬇️
...enapi_core/deserializing/media_types/exceptions.py 87.50% <100.00%> (ø)
... and 12 more

@p1c2u p1c2u force-pushed the feature/request-response-binary-format-support branch from 44c6048 to 10fdbea Compare November 1, 2023 19:50
@p1c2u p1c2u merged commit 09f065b into master Nov 1, 2023
17 of 18 checks passed
@p1c2u p1c2u deleted the feature/request-response-binary-format-support branch November 1, 2023 19:59
miketheman added a commit to miketheman/pyramid_openapi3 that referenced this pull request Mar 7, 2024
The underling openapi-code library changed how they pass back the
response body in 0.19

Refs: python-openapi/openapi-core#710

Co-authored-by: Wim De Clercq <declewi@gmail.com>
Signed-off-by: Mike Fiedler <miketheman@gmail.com>
miketheman added a commit to miketheman/pyramid_openapi3 that referenced this pull request Mar 7, 2024
The underlying openapi-code library changed how they pass back the
response body in 0.19

Refs: python-openapi/openapi-core#710

Co-authored-by: Wim De Clercq <declewi@gmail.com>
Signed-off-by: Mike Fiedler <miketheman@gmail.com>
zupo pushed a commit to Pylons/pyramid_openapi3 that referenced this pull request Mar 7, 2024
The underlying openapi-code library changed how they pass back the
response body in 0.19

Refs: python-openapi/openapi-core#710

Co-authored-by: Wim De Clercq <declewi@gmail.com>
Signed-off-by: Mike Fiedler <miketheman@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant