Use mmap instead of built-in Win32 mapper #5224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 25, 2021
|
See https://gist.github.com/raygard/3615f737e448ba1bf7a45874772db1c7 for a test. I don't know how this needs to be set up for CI testing, etc. But it does demonstrate the before/after behavior you need. |
|
I have added a test, using the initial comment in #5221 By itself, this test causes a 'Windows fatal exception: access violation'. With the change from this PR, it passes. |
|
Thanks all! |
radarhere
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #5221, as reported by the user who created that issue.
Recreated version of #4310, since it needed to be rebased and the Pillow repository from @cgohlke has disappeared.