Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 2.7.0 on January 1, 2015 #949

Closed
aclark4life opened this issue Oct 7, 2014 · 26 comments
Closed

Release 2.7.0 on January 1, 2015 #949

aclark4life opened this issue Oct 7, 2014 · 26 comments
Labels
Milestone

Comments

@aclark4life
Copy link
Member

OK I'm dropping off again, please use @aclark4life if you need anything or email aclark@aclark.net. Thank you 🍻

@hugovk hugovk added the Release label Oct 8, 2014
@hugovk hugovk added this to the 2.7.0 milestone Oct 26, 2014
@aclark4life
Copy link
Member Author

I'm back! How are we looking for Jan 1 @hugovk @wiredfool ?

@hugovk
Copy link
Member

hugovk commented Dec 28, 2014

We have eight open PRs, two aren't ready: #897 and the experimental #1013. #1054 doesn't have tests but it's not a showstopper if we want it in the release.

@wiredfool
Copy link
Member

I'm digging out from under visitors and getting my wrist working well again. hoping to have some good time to work through stuff tonight.

@wiredfool
Copy link
Member

I've merged #1054, I think it's ready enough. We're down to only PRs that I don't think should be merged for the release.

At this point, I think we should draw a line and only fix regressions or documentation.

@aclark4life
Copy link
Member Author

Great!

@wiredfool
Copy link
Member

I've run the tests on my PPC/bigendian machine and we're only getting the usual known issues with Jpeg2k.

@cgohlke
Copy link
Contributor

cgohlke commented Dec 31, 2014

I get two test failures/errors on Windows. The error is trivial. The Scipy is version 0.14.1:

======================================================================
ERROR: TestImageFont.test_find_linux_font
----------------------------------------------------------------------
Traceback (most recent call last):
  File "D:\Build\Pillow\Pillow-git\Tests\test_imagefont.py", line 246, in test_find_linux_font
    self._test_fake_loading_font('/usr/local/share/fonts/Arial.ttf')
  File "D:\Build\Pillow\Pillow-git\Tests\test_imagefont.py", line 229, in _test_fake_loading_font
    font = ImageFont.truetype('Arial')
  File "D:\Build\Pillow\Pillow-git\PIL\ImageFont.py", line 266, in truetype
    return FreeTypeFont(filepath, size, index, encoding)
  File "D:\Build\Pillow\Pillow-git\Tests\test_imagefont.py", line 227, in loadable_font
    return ImageFont._FreeTypeFont(filepath, size, index, encoding)
  File "D:\Build\Pillow\Pillow-git\PIL\ImageFont.py", line 137, in __init__
    self.font = core.getfont(font, size, index, encoding)
IOError: cannot open resource

======================================================================
FAIL: Test_scipy_resize.test_imresize4
----------------------------------------------------------------------
Traceback (most recent call last):
  File "D:\Build\Pillow\Pillow-git\Tests\test_scipy.py", line 38, in test_imresize4
    assert_equal(im2, res)
  File "X:\Python27-x64\lib\site-packages\numpy\testing\utils.py", line 260, in assert_equal
    return assert_array_equal(actual, desired, err_msg, verbose)
  File "X:\Python27-x64\lib\site-packages\numpy\testing\utils.py", line 718, in assert_array_equal
    verbose=verbose, header='Arrays are not equal')
  File "X:\Python27-x64\lib\site-packages\numpy\testing\utils.py", line 644, in assert_array_compare
    raise AssertionError(msg)
AssertionError:
Arrays are not equal

(mismatch 75.0%)
 x: array([[ 1.  ,  1.25,  1.75,  2.  ],
       [ 1.5 ,  1.75,  2.25,  2.5 ],
       [ 2.5 ,  2.75,  3.25,  3.5 ],
       [ 3.  ,  3.25,  3.75,  4.  ]], dtype=float32)
 y: array([[ 1. ,  1. ,  1.5,  2. ],
       [ 1. ,  1. ,  1.5,  2. ],
       [ 2. ,  2. ,  2.5,  3. ],
       [ 3. ,  3. ,  3.5,  4. ]], dtype=float32)

----------------------------------------------------------------------

@wiredfool
Copy link
Member

The font one should probably only run on the appropriate platform, or at least, not windows. I'll look at scipy more closely.

@wiredfool
Copy link
Member

I've got to say, the existing one doesn't exactly look right. But it's not like it's getting tested on travis, since Ubuntu 12.04 ships with scipy 0.9, which doesn't even have the imresize method. Not that we're installing it to find that out.

I'm assuming that that has passed in the past?

@wiredfool
Copy link
Member

OK, I found these -- they're from the scipy tests, and were added after the last release. https://github.com/scipy/scipy/blob/master/scipy/misc/tests/test_pilutil.py

@wiredfool
Copy link
Member

The scipy change appears to be because of a change in the way that image resizing works. The new version looks more reasonable to me, which fits with the conclusions that we've had from the changes in the resizing code this iteration.

@wiredfool
Copy link
Member

@cgohlke Check master now.

Also as a heads up, I'm planning on a 2.6.2 release tomorrow with the PNG dos fix. When the tests pass on my branch, I'll push the last changes in. (it's 2.6.1 + png dos fix + pypy2.4 regression fix + reverting the test changes on for pypy2.4)

@wiredfool
Copy link
Member

Ok, versions bumped. 12 hours or so till I tag & push.

@cgohlke
Copy link
Contributor

cgohlke commented Jan 1, 2015

Looks good. All test pass.

@wiredfool
Copy link
Member

Ok, 2.7.0 and 2.6.2 are tagged and released.

@aclark4life
Copy link
Member Author

Great, thanks @wiredfool @hugovk @cgohlke et al. Happy new year!

@aclark4life
Copy link
Member Author

Uploading…

@aclark4life
Copy link
Member Author

Done, thanks (Twine now supports exe!)

@wiredfool
Copy link
Member

You beat me to it.

also yay about exes.

@wiredfool
Copy link
Member

OSX binaries are up now.

@stonebig
Copy link

hi,

Excuse-me, if I'm not wrong, with latest @cgohlke wheelaries for pillow2.7.0 and scipy0.14.1, I have still the issue on windows 64bit python3.4.2.... What detail can I have missed ?

======================================================================
FAIL: test_imresize4 (test_pilutil.TestPILUtil)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "D:\result_tests\WinPython-64bit-3.4.2.4_build5FlavorRfull\python-3.4.2.amd64\lib\site-packages\numpy\testing\decorators.py", line 146, in skipper_func
    return f(*args, **kwargs)
  File "D:\result_tests\WinPython-64bit-3.4.2.4_build5FlavorRfull\python-3.4.2.amd64\lib\site-packages\scipy\misc\tests\test_pilutil.py", line 57, in test_imresize4
    assert_equal(im2, res)
  File "D:\result_tests\WinPython-64bit-3.4.2.4_build5FlavorRfull\python-3.4.2.amd64\lib\site-packages\numpy\testing\utils.py", line 275, in assert_equal
    return assert_array_equal(actual, desired, err_msg, verbose)
  File "D:\result_tests\WinPython-64bit-3.4.2.4_build5FlavorRfull\python-3.4.2.amd64\lib\site-packages\numpy\testing\utils.py", line 739, in assert_array_equal
    verbose=verbose, header='Arrays are not equal')
  File "D:\result_tests\WinPython-64bit-3.4.2.4_build5FlavorRfull\python-3.4.2.amd64\lib\site-packages\numpy\testing\utils.py", line 665, in assert_array_compare
    raise AssertionError(msg)
AssertionError: 
Arrays are not equal

(mismatch 75.0%)
 x: array([[ 1.  ,  1.25,  1.75,  2.  ],
       [ 1.5 ,  1.75,  2.25,  2.5 ],
       [ 2.5 ,  2.75,  3.25,  3.5 ],
       [ 3.  ,  3.25,  3.75,  4.  ]], dtype=float32)
 y: array([[ 1. ,  1. ,  1.5,  2. ],
       [ 1. ,  1. ,  1.5,  2. ],
       [ 2. ,  2. ,  2.5,  3. ],
       [ 3. ,  3. ,  3.5,  4. ]], dtype=float32)

@hugovk
Copy link
Member

hugovk commented Jan 10, 2015

@stonebig Which issue are you referring to? Was there a bug reported here about it?

@stonebig
Copy link

the effect is apparently the same FAIL @cgohlke complained about #949 (comment)
when doing:

import scipy;scipy.test()

same FAIL also in 32bit python3.4.2.

As I didn't understand exactly what the fix was, I' not sure what I have to re-check, re-do.

@aclark4life
Copy link
Member Author

@stonebig Can you please open a new issue to report this problem? Thanks

@homm
Copy link
Member

homm commented Jan 10, 2015

@stonebig This is obviously very bad scipy developers idea to test third-party functionality in it's own unit tests. This is wrong result of bilinear interpolation produced by previous Pillow and PIL version. This is definitely scipy issue, not Pillow.

@stonebig
Copy link

@aclark4life done ! #1074

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants