-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 2.7.0 on January 1, 2015 #949
Comments
I'm back! How are we looking for Jan 1 @hugovk @wiredfool ? |
We have eight open PRs, two aren't ready: #897 and the experimental #1013. #1054 doesn't have tests but it's not a showstopper if we want it in the release. |
I'm digging out from under visitors and getting my wrist working well again. hoping to have some good time to work through stuff tonight. |
I've merged #1054, I think it's ready enough. We're down to only PRs that I don't think should be merged for the release. At this point, I think we should draw a line and only fix regressions or documentation. |
Great! |
I've run the tests on my PPC/bigendian machine and we're only getting the usual known issues with Jpeg2k. |
I get two test failures/errors on Windows. The error is trivial. The Scipy is version 0.14.1:
|
The font one should probably only run on the appropriate platform, or at least, not windows. I'll look at scipy more closely. |
I've got to say, the existing one doesn't exactly look right. But it's not like it's getting tested on travis, since Ubuntu 12.04 ships with scipy 0.9, which doesn't even have the imresize method. Not that we're installing it to find that out. I'm assuming that that has passed in the past? |
OK, I found these -- they're from the scipy tests, and were added after the last release. https://github.com/scipy/scipy/blob/master/scipy/misc/tests/test_pilutil.py |
The scipy change appears to be because of a change in the way that image resizing works. The new version looks more reasonable to me, which fits with the conclusions that we've had from the changes in the resizing code this iteration. |
@cgohlke Check master now. Also as a heads up, I'm planning on a 2.6.2 release tomorrow with the PNG dos fix. When the tests pass on my branch, I'll push the last changes in. (it's 2.6.1 + png dos fix + pypy2.4 regression fix + reverting the test changes on for pypy2.4) |
Ok, versions bumped. 12 hours or so till I tag & push. |
Looks good. All test pass. |
Ok, 2.7.0 and 2.6.2 are tagged and released. |
Great, thanks @wiredfool @hugovk @cgohlke et al. Happy new year! |
Uploading… |
Done, thanks (Twine now supports exe!) |
You beat me to it. also yay about exes. |
OSX binaries are up now. |
hi, Excuse-me, if I'm not wrong, with latest @cgohlke wheelaries for pillow2.7.0 and scipy0.14.1, I have still the issue on windows 64bit python3.4.2.... What detail can I have missed ?
|
@stonebig Which issue are you referring to? Was there a bug reported here about it? |
the effect is apparently the same FAIL @cgohlke complained about #949 (comment)
same FAIL also in 32bit python3.4.2. As I didn't understand exactly what the fix was, I' not sure what I have to re-check, re-do. |
@stonebig Can you please open a new issue to report this problem? Thanks |
@stonebig This is obviously very bad scipy developers idea to test third-party functionality in it's own unit tests. This is wrong result of bilinear interpolation produced by previous Pillow and PIL version. This is definitely scipy issue, not Pillow. |
@aclark4life done ! #1074 |
OK I'm dropping off again, please use @aclark4life if you need anything or email aclark@aclark.net. Thank you 🍻
The text was updated successfully, but these errors were encountered: