Add functions to Image: static fromqimage and fromqpixmap; methods toqimage and toqpixmap

[rominf]

I'm writing Qt application that needs diff feature of Pillow Image. So, I need to convert QPixmap to Image and and vice versa.

I've found existing class ImageQt. But I don't like it. It contains just one __init__ function. In this case using class is not required. I would say it's misleading.

I'm gonna prepare functions for Image class: static fromqimage and fromqpixmap; methods toqimage and toqpixmap.

Those functions would be defined only if PyQt is installed.

What do you think?

PS: I would like to change from* functions to from_* due readability. But I want to be consistent. If you like from* more, I would write fromqpixmap, etc.

[wiredfool]

I think that they'd probably be better off in the ImageQt module.

The ImageQt class is essentially a class based version of toqimage. Apparently it used to wrap rather than extend QImage. I'm not clear on the reasoning behind that, being 8 years ago and not familiar with PyQT code styles.

It seems reasonable to have to/from versions for converting between PIL.Images and QImages and QPixmaps.

For better or worse, the current style on to/from is smushed words, not _ words.

[rominf]

I'm using PyQt for a long time. There is no reason to subclass QImage in this case.

I understand your intent to separate Qt specific code from anything else. I will put everything related Qt into separate file qt.py (or ImageQt.py if you want) and then, in the image.py I will put:

import qt
if qt.is_installed:
    from qt import fromqimage, toqimage, fromqpixmap, toqpixmap

[aclark4life]

Looks like this was shipped in 2.7.0

[hugovk]

It wasn't shipped in 2.7.0: its PR is still open but not ready for merge.
#905

[aclark4life]

Thanks

[radarhere]

This change has been merged with PR #1217 and so this issue can be closed.