Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix errors when using the --help option #1910

Merged
merged 1 commit into from Jan 31, 2020
Merged

Conversation

@sdispater
Copy link
Member

sdispater commented Jan 17, 2020

Pull Request Check List

  • Added tests for changed code.
  • Updated documentation for changed code.

This PR fixes the behavior of the --help option for some commands where it would cause an error. This was due to the fact that we were trying to resolve an incomplete command. Now if the command cannot be resolved we will fall back on the default CliKit behavior.

Fixes #1625

@sdispater sdispater added Bug CLI labels Jan 17, 2020
@sdispater sdispater requested a review from python-poetry/core Jan 17, 2020
@sdispater sdispater mentioned this pull request Jan 20, 2020
3 of 3 tasks complete
@sdispater sdispater merged commit 4897a70 into master Jan 31, 2020
32 checks passed
32 checks passed
Linting
Details
Linting
Details
Linux (2.7)
Details
Linux (2.7)
Details
Linux (3.5)
Details
Linux (3.5)
Details
Linux (3.6)
Details
Linux (3.6)
Details
Linux (3.7)
Details
Linux (3.7)
Details
Linux (3.8)
Details
Linux (3.8)
Details
MacOS (2.7)
Details
MacOS (2.7)
Details
MacOS (3.5)
Details
MacOS (3.5)
Details
MacOS (3.6)
Details
MacOS (3.6)
Details
MacOS (3.7)
Details
MacOS (3.7)
Details
MacOS (3.8)
Details
MacOS (3.8)
Details
Windows (2.7)
Details
Windows (2.7)
Details
Windows (3.5)
Details
Windows (3.5)
Details
Windows (3.6)
Details
Windows (3.6)
Details
Windows (3.7)
Details
Windows (3.7)
Details
Windows (3.8)
Details
Windows (3.8)
Details
@sdispater sdispater deleted the fix-help-option-behavior branch Jan 31, 2020
MrGreenTea added a commit to MrGreenTea/poetry that referenced this pull request Feb 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

1 participant
You can’t perform that action at this time.