Version parsing for Postgres 10 does not work

[ypicard]

When trying to connect to a Postgres 10.3, version parsing seems to fails

[0atman]

I think I'm having the same problem, here's a stacktrace:

[...]
        c.connect()
      File "[...]lib/python3.6/site-packages/postgres
ql/driver/dbapi20.py", line 354, in connect
        super().connect(*args, **kw)
      File "[...]lib/python3.6/site-packages/postgres
ql/driver/pq3.py", line 2422, in connect
        self._establish()
      File "[...]lib/python3.6/site-packages/postgres
ql/driver/pq3.py", line 2554, in _establish
        self.version_info = pg_version.normalize(pg_version.split(sv))
      File "[...]lib/python3.6/site-packages/postgres
ql/versionstring.py", line 28, in split
        vlist = [int(x or '0') for x in v[:-1]]
      File "[...]lib/python3.6/site-packages/postgres
ql/versionstring.py", line 28, in <listcomp>
        vlist = [int(x or '0') for x in v[:-1]]
    ValueError: invalid literal for int() with base 10: '2 (Ubuntu 10'```

[0atman]

My version when connecting with psql is:

psql (10.2 (Ubuntu 10.2-1))

I bet it's expecting just 10.2

[0atman]

switching to psycopg2 fixed it in my app

[jwp]

Not sure how "ubuntu" is making its way into a PostgreSQL version string.

[0atman]

Postgres 10 has system names in version strings, which seems to always fail this check. I'd that code in this library?

[jwp]

Looks like a ubuntu feature:

>>> import postgresql
>>> db=postgresql.open('pq://localhost:5432/postgres')
>>> db
<postgresql.driver.pq3.Connection[pq://localhost:5432/postgres] b'I'>
>>> db.version_info
(10, 3, 0, 'final', 0)

[0atman]

hey, you've got a string (final) in your version too, why doesn't that fail in the same way as mine?

[jwp]

>>> import postgresql.versionstring as vs
>>> vs.split('10.3')
(10, 3, None, None, None)
>>> vs.split('10.3final')
(10, 3, None, 'final', None)
>>> vs.split('10.3final1')
(10, 3, None, 'final', 1)