Skip to content

Conversation

jessekv
Copy link

@jessekv jessekv commented Jan 30, 2020

The new(ish) Wildcard field does not get registered in the docs because it isn't checked for when registering fields. This PR is a monkeypatch I have been using, but I think it is the correct behaviour.

@ziirish
Copy link
Contributor

ziirish commented Jan 30, 2020

Hello,

Thanks for your contribution.
Could you please add a bit more context such as a snippet in order to reproduce the issue or a screenshot?

I think I understand the problem, but adding those details will help for future references.

Thanks

@jessekv
Copy link
Author

jessekv commented Jan 30, 2020

Some screenshots. Notice the missing DataArray submodel in the Wildcard field (< * >).

Before:
image

After:
image

@ziirish
Copy link
Contributor

ziirish commented Jan 30, 2020

Thanks!

Copy link
Contributor

@ziirish ziirish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jessekv jessekv changed the title register wildcard fields in docs register nested model wildcard fields in docs Jan 30, 2020
@ziirish ziirish merged commit b613f08 into python-restx:master Feb 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants