Skip to content

Deterministic file loading and vulnerability order #165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 14, 2018
Merged

Deterministic file loading and vulnerability order #165

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fe058b0
Deterministic file loading and vulnerability order
bcaller Aug 13, 2018
d6ad59f
Don't repeat get_modules call if we use a project root
bcaller Aug 13, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions pyt/__main__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,15 +79,18 @@ def main(command_line_args=sys.argv[1:]): # noqa: C901

nosec_lines = defaultdict(set)

for path in files:
if args.project_root:
directory = os.path.normpath(args.project_root)
project_modules = get_modules(directory, prepend_module_root=args.prepend_module_root)

for path in sorted(files):
Copy link
Collaborator

@KevinHock KevinHock Aug 14, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Such a great idea I don't think I would have ever thought of 😁

if not args.ignore_nosec:
nosec_lines[path] = retrieve_nosec_lines(path)

if args.project_root:
directory = os.path.normpath(args.project_root)
else:
if not args.project_root:
directory = os.path.dirname(path)
project_modules = get_modules(directory, prepend_module_root=args.prepend_module_root)
project_modules = get_modules(directory, prepend_module_root=args.prepend_module_root)

local_modules = get_directory_modules(directory)
tree = generate_ast(path)

Expand Down