Test running pyt in a python 3.7 env #193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It should just work. There were no AST changes. Also removes the unnecesary whitelist_external from tox.ini. Note: pyt can be run in a py36 environment on code targeting 2.7-3.8. There is no requirement for pyt to be run under the same environment as your code is intended to run in. Running pyt under 3.8 will require some further work due to the change from ast.Str to ast.Constant: https://github.com/python/cpython/pull/9445/files https://docs.python.org/dev/whatsnew/3.8.html#deprecated https://bugs.python.org/issue32892
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It should just work. There were no AST changes.
Also removes the unnecesary
whitelist_externalfrom tox.ini.Note: pyt can be run in a py36 environment on code targeting 2.7-3.8.
There is no requirement for pyt to be run under the same environment as
your code is intended to run in.
Running pyt under 3.8 will require some further work due to the change
from
ast.Strtoast.Constant:https://github.com/python/cpython/pull/9445/files
https://docs.python.org/dev/whatsnew/3.8.html#deprecated
https://bugs.python.org/issue32892
Closes #192