-
-
Notifications
You must be signed in to change notification settings - Fork 380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PEP621: Migrate setup.py config into pyproject.toml #421
Conversation
Codecov Report
@@ Coverage Diff @@
## master #421 +/- ##
==========================================
+ Coverage 93.59% 93.80% +0.20%
==========================================
Files 34 34
Lines 1078 1113 +35
Branches 63 130 +67
==========================================
+ Hits 1009 1044 +35
Misses 44 44
Partials 25 25
Flags with carried forward coverage won't be shown. Click here to find out more. see 9 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
"Programming Language :: Python :: 3.11", | ||
"Topic :: Internet" | ||
] | ||
dependencies = ["social-auth-core >= 4.1.0"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we remove the requirements.txt? If you think it's too big change to do in this PR, please create another PR on top of this so that we can see a full scope of changes this will bring. Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO first remove dependencies
from setup.py as a separate PR and then come back to this.
Update: this is already inside the removed requirements.txt
.
codecov==2.1.12 | ||
pre-commit==2.21.0; python_version < '3.8' | ||
pre-commit==3.1.1; python_version >= '3.8' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Already updated in #434 so I think you can drop this change.
tox==4.4.7 | ||
-r requirements.txt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why remove requirements.txt ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps read the commit message.
Proposed changes
Describe the big picture of your changes here to communicate to the maintainers
why we should accept this pull request. If it fixes a bug or resolves a feature
request, be sure to link to that issue.
PEP621 encourages the Python community to migrate away from complex
setup.cfg
+setup.py
files by putting config data inpyproject.toml
.Migrate
setup.py
tosetup.cfg
using setuptools-py2cfg plus manual modifications.Then migrate
setup.cfg
topyproject.toml
using ini2toml to do the file conversion and running validate-pyproject in pre-commit to validate the results.Types of changes
Please check the type of change your PR introduces:
Checklist
Put an
x
in the boxes that apply. You can also fill these out after creatingthe PR. If you're unsure about any of them, don't hesitate to ask. We're here to
help! This is simply a reminder of what we are going to look for before merging
your code.
Other information
Any other information that is important to this PR such as screenshots of how
the component looks before and after the change.