Skip to content

Add effective_name property to Chat object #3485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 6, 2023

Conversation

Viicos
Copy link
Contributor

@Viicos Viicos commented Jan 5, 2023

Fixes #3480.

Checklist for PRs

  • Added .. versionadded:: version, .. versionchanged:: version or .. deprecated:: version to the docstrings for user facing

@Viicos
Copy link
Contributor Author

Viicos commented Jan 5, 2023

Let me know which .. versionadded:: should be used, and if this property name is fine

@Poolitzer
Copy link
Member

@Viicos I would call it effective_name, and it needs a test

@clot27
Copy link
Member

clot27 commented Jan 5, 2023

Let me know which .. versionadded:: should be used, and if this property name is fine

the next release will be v20.1

@Viicos Viicos changed the title Add chat_title property to Chat object Add effective_name property to Chat object Jan 5, 2023
This also fixes a comma in another docstring.
Copy link
Member

@clot27 clot27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Bibo-Joshi Bibo-Joshi merged commit d48fa71 into python-telegram-bot:master Jan 6, 2023
@Bibo-Joshi
Copy link
Member

Thank you very much for your contribution :)

@github-actions github-actions bot locked and limited conversation to collaborators Jan 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] convenience property for displaying name of Chat object
4 participants