Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed vscode folder #20

Merged
merged 2 commits into from
Dec 11, 2023

Conversation

ShiroTohu
Copy link
Contributor

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Breaking Change
  • Documentation Update

Description

I saw that .vscode was in the root structure of the project. I thought this was odd because to my knowledge, the .vscode folder is meant to store the settings for the User and Workplace environments. Also a bit worried that the folder would somehow end up on live. Therefore, I have done these two things.

  • Removed .vscode/ from repository
  • Added .vscode/ to .gitignore

Hope these small changes can help you out!
bouncing cat

Added/updated tests?

We encourage you to keep the code coverage percentage at 80% and above.

  • Yes
  • No, and this is why: minor change that doesn't need any tests.
  • I need help with writing tests

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@caffeine-addictt caffeine-addictt added Type: Enhancement Suggest an improvement for an existing feature. Priority: Low - Task is considered lower-priority. labels Dec 11, 2023
@caffeine-addictt
Copy link
Member

Hi! Thanks for contributing @ShiroTohu.
Release builds only the src/thread/ directory so the .vscode/ directory will not be included in live.

However, yea, it is something i forgot to remove. Thanks for pointing it out 😄

.gitignore Show resolved Hide resolved
.vscode/settings.json Show resolved Hide resolved
@caffeine-addictt caffeine-addictt merged commit 98dc961 into python-thread:main Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: Low - Task is considered lower-priority. Type: Enhancement Suggest an improvement for an existing feature.
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants