Fix TaskStatus.started() being a no-op when in an effectively cancelled scope
#2896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…) around the tree
Specifically, make started() reparent the task even if the start() call is in an effectively cancelled scope when started() is called, and check sys.exc_info() to prevent calling task_status.started() while handling active Cancelled(s).
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2896 +/- ##
==========================================
- Coverage 99.68% 99.57% -0.11%
==========================================
Files 117 117
Lines 17546 17579 +33
Branches 3152 3161 +9
==========================================
+ Hits 17490 17505 +15
- Misses 38 50 +12
- Partials 18 24 +6
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
proposed patch and tests to fix #2895 and close #2544.