Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix TaskStatus.started() being a no-op when in an effectively cancelled scope #2896

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Fix TaskStatus.started() being a no-op when in an effectively cancelled scope #2896

wants to merge 6 commits into from

Commits on Apr 24, 2023

  1. Test that TaskStatus.started() never returns success upon failure

    @gschaffner
    gschaffner committed Apr 24, 2023
    Configuration menu
    Copy the full SHA
    d00e115 View commit details
    Browse the repository at this point in the history

  2. Test that TaskStatus.started() does not allow teleporting Cancelled(s… 

    …) around the tree
    @gschaffner
    gschaffner committed Apr 24, 2023
    Configuration menu
    Copy the full SHA
    39bc92a View commit details
    Browse the repository at this point in the history

  3. Make TaskStatus.started() never return success upon failure 

    Specifically, make started() reparent the task even if the start() call
is in an effectively cancelled scope when started() is called, and check
sys.exc_info() to prevent calling task_status.started() while handling
active Cancelled(s).
    @gschaffner
    gschaffner committed Apr 24, 2023
    Configuration menu
    Copy the full SHA
    b038de5 View commit details
    Browse the repository at this point in the history

Commits on Dec 13, 2023

  1. Merge branch 'master' into fix-start-cancellation

    @CoolCat467
    CoolCat467 authored Dec 13, 2023
    Configuration menu
    Copy the full SHA
    edb1ddf View commit details
    Browse the repository at this point in the history

  2. Fix ruff issue

    @CoolCat467
    CoolCat467 committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    8933cee View commit details
    Browse the repository at this point in the history

Commits on Jan 9, 2024

  1. Merge branch 'master' into fix-start-cancellation

    @CoolCat467
    CoolCat467 authored Jan 9, 2024
    Configuration menu
    Copy the full SHA
    651b51a View commit details
    Browse the repository at this point in the history