Tweak API #59
Merged
Tweak API #59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The public API is unasync.unasync_files now.
It clarifies that we're only adding replacement, not replacing the existing ones. Also, black tends to put this on a single line, so we the additional characters are not a problem in practice.
Codecov Report
@@ Coverage Diff @@
## master #59 +/- ##
=======================================
Coverage 97.63% 97.63%
=======================================
Files 2 2
Lines 127 127
Branches 31 31
=======================================
Hits 124 124
Misses 1 1
Partials 2 2
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
replacementstoadditional_replacements(this is the name that Seth wanted to use initially, and it's just better)Rule.unasync_fileas private, now thatunasync.unasync_filesexists