Skip to content

Conversation

penguinolog
Copy link
Collaborator

What do these changes do?

Support work without STDOUT and/or STDERR

Are there changes in behavior for the user?

possible to call commands with open_stdout = False and open_stderr = False in cases,
when STDOUT and/or STDERR is not required.

Related issue number

issue: #5

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes

@penguinolog penguinolog added the enhancement New feature or request label Mar 29, 2018
result = runner.execute(command, open_stdout=False, open_stderr=False)
self.assertEqual(
result, exp_result

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

useless blank line

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@coveralls
Copy link
Collaborator

coveralls commented Mar 29, 2018

Pull Request Test Coverage Report for Build 58

  • 15 of 15 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+1.5%) to 99.078%

Totals Coverage Status
Change from base Build 53: 1.5%
Covered Lines: 860
Relevant Lines: 868

💛 - Coveralls

espositocloud
espositocloud previously approved these changes Mar 29, 2018
@penguinolog penguinolog merged commit 2db2c5c into python-useful-helpers:master Mar 29, 2018
@penguinolog penguinolog deleted the no_stdout_stderr branch March 29, 2018 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants