Skip to content

Return nonblocking mode for subprocess pipe polling #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 3, 2018
Merged

Return nonblocking mode for subprocess pipe polling #14

merged 1 commit into from
Apr 3, 2018

Conversation

penguinolog
Copy link
Collaborator

What do these changes do?

Return nonblocking mode for subprocess pipe polling
Use windows specific calls on windows to unblock pipe
Checked: linux & Windows 10x64

Are there changes in behavior for the user?

Real-time logging and return deadlock-proof work

Related issue number

N/A

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes

@penguinolog penguinolog added the enhancement New feature or request label Apr 3, 2018
@penguinolog penguinolog added this to the 1.2.0 milestone Apr 3, 2018
@coveralls
Copy link
Collaborator

coveralls commented Apr 3, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 62

  • 10 of 11 (90.91%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.3%) to 98.967%
Changes Missing Coverage Covered Lines Changed/Added Lines %
exec_helpers/subprocess_runner.py 10 11 90.91%
Totals Coverage Status
Change from base Build 61: 0.3%
Covered Lines: 862
Relevant Lines: 871
💛 - Coveralls

1 similar comment
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 62

  • 10 of 11 (90.91%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.3%) to 98.967%
Changes Missing Coverage Covered Lines Changed/Added Lines %
exec_helpers/subprocess_runner.py 10 11 90.91%
Totals Coverage Status
Change from base Build 61: 0.3%
Covered Lines: 862
Relevant Lines: 871
💛 - Coveralls

@penguinolog penguinolog merged commit 626efc8 into python-useful-helpers:master Apr 3, 2018
@penguinolog penguinolog deleted the nonblock_subprocess branch April 3, 2018 10:30
@penguinolog
Return nonblocking mode for subprocess pipe polling
0c48746 
Use windows specific calls on windows to unblock pipe
Checked: linux & Windows 10x64
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@espositocloud espositocloud espositocloud approved these changes

@dis-xcom dis-xcom Awaiting requested review from dis-xcom dis-xcom is a code owner

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

1.2.0

Development

Successfully merging this pull request may close these issues.

3 participants

@penguinolog @coveralls @espositocloud