Skip to content

Conversation

penguinolog
Copy link
Collaborator

What do these changes do?

Set default timeout to 1 hour.
Also check for future imports and add from __future__ import division

Are there changes in behavior for the user?

Default timeout for command is 1 hour instead of infinite wait.

Related issue number

Fix #15

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes

Also check for future imports and add `from __future__ import division`
@penguinolog penguinolog added the enhancement New feature or request label Apr 5, 2018
@penguinolog penguinolog added this to the 1.2.0 milestone Apr 5, 2018
@coveralls
Copy link
Collaborator

coveralls commented Apr 5, 2018

Pull Request Test Coverage Report for Build 65

  • 24 of 24 (100.0%) changed or added relevant lines in 9 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.09%) to 98.878%

Files with Coverage Reduction New Missed Lines %
exec_helpers/subprocess_runner.py 1 95.73%
Totals Coverage Status
Change from base Build 63: -0.09%
Covered Lines: 881
Relevant Lines: 891

💛 - Coveralls

@@ -0,0 +1,27 @@
# Copyright 2018 Alexey Stepanov aka penguinolog.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should not be the same of the other files?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah I realized that it's actually consistent. Never mind.

@penguinolog penguinolog merged commit 7e0d26c into python-useful-helpers:master Apr 5, 2018
@penguinolog penguinolog deleted the default_timeout branch April 5, 2018 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants