Skip to content

Fix docstrings ans :raises: constructions. #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 6, 2018
Merged

Fix docstrings ans :raises: constructions. #17

merged 1 commit into from
Apr 6, 2018

Conversation

penguinolog
Copy link
Collaborator

What do these changes do?

Fix docstrings ans :raises: constructions.
Divorce DeserializeValueError from ExecHelperError

Are there changes in behavior for the user?

Divorce DeserializeValueError from ExecHelperError

Related issue number

N/A

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes

@penguinolog penguinolog added the enhancement New feature or request label Apr 6, 2018
@penguinolog penguinolog added this to the 1.2.0 milestone Apr 6, 2018
@espositocloud
Copy link
Contributor

Typo in the commit message

@penguinolog
Fix docstrings and :raises: constructions.
a8050b0 
Divorce DeserializeValueError from ExecHelperError
@penguinolog
Copy link
Collaborator Author

Commit message fixed

@coveralls
Copy link
Collaborator

coveralls commented Apr 6, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 68

  • 4 of 4 (100.0%) changed or added relevant lines in 2 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.1%) to 98.88%
Files with Coverage Reduction New Missed Lines %
exec_helpers/proc_enums.py 1 99.07%
Totals Coverage Status
Change from base Build 66: -0.1%
Covered Lines: 883
Relevant Lines: 893
💛 - Coveralls

@penguinolog penguinolog merged commit 0f78eff into python-useful-helpers:master Apr 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@espositocloud espositocloud espositocloud approved these changes

@dis-xcom dis-xcom Awaiting requested review from dis-xcom dis-xcom is a code owner

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

1.2.0

Development

Successfully merging this pull request may close these issues.

3 participants

@penguinolog @espositocloud @coveralls