Skip to content

Conversation

penguinolog
Copy link
Collaborator

What do these changes do?

Allow masking part of command in logs

Are there changes in behavior for the user?

Allow masking part of command in logs using regex groups

Related issue number

#13

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes

@penguinolog penguinolog added the enhancement New feature or request label Apr 12, 2018
@penguinolog penguinolog added this to the 1.2.0 milestone Apr 12, 2018
@coveralls
Copy link
Collaborator

coveralls commented Apr 12, 2018

Pull Request Test Coverage Report for Build 71

  • 87 of 89 (97.75%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 99.014%

Changes Missing Coverage Covered Lines Changed/Added Lines %
exec_helpers/_ssh_client_base.py 15 16 93.75%
exec_helpers/subprocess_runner.py 11 12 91.67%
Totals Coverage Status
Change from base Build 69: 0.02%
Covered Lines: 904
Relevant Lines: 913

💛 - Coveralls

@penguinolog penguinolog merged commit 1c34740 into python-useful-helpers:master Apr 12, 2018
@penguinolog penguinolog deleted the mask_cmd branch April 12, 2018 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants