Skip to content

CalledProcessError should store execution result #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 27, 2018
Merged

CalledProcessError should store execution result #2

merged 2 commits into from
Mar 27, 2018

Conversation

penguinolog
Copy link
Collaborator

During migration found missed API

@penguinolog penguinolog added the enhancement New feature or request label Mar 26, 2018
@coveralls
Copy link
Collaborator

coveralls commented Mar 26, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 39

  • 13 of 13 (100.0%) changed or added relevant lines in 2 files are covered.
  • 5 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.7%) to 95.647%
Files with Coverage Reduction New Missed Lines %
exec_helpers/subprocess_runner.py 1 88.89%
exec_helpers/_ssh_client_base.py 4 97.88%
Totals Coverage Status
Change from base Build 36: 0.7%
Covered Lines: 813
Relevant Lines: 850
💛 - Coveralls

@penguinolog penguinolog merged commit 5456216 into python-useful-helpers:master Mar 27, 2018
@penguinolog penguinolog deleted the CalledProcessError branch March 27, 2018 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@espositocloud espositocloud espositocloud approved these changes

@dis-xcom dis-xcom Awaiting requested review from dis-xcom dis-xcom is a code owner

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@penguinolog @coveralls @espositocloud