Skip to content

Make global execute and move to _api. Fix #19 Fix #21 #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
May 2, 2018
Merged

Make global execute and move to _api. Fix #19 Fix #21 #26

merged 6 commits into from
May 2, 2018

Conversation

penguinolog
Copy link
Collaborator

Are there changes in behavior for the user?

execute_async both in Subprocess and SSH
get_pty at SSH moved to **kwargs

Related issue number

#19
#21

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes

@penguinolog
Make global execute and move to _api. Fix #19 Fix #21
c58b7b4 
* execute_async both in Subprocess and SSH
* `get_pty` at SSH moved to `**kwargs`
*

* Code-style: switch to 120 symbols/line
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 85

  • 72 of 89 (80.9%) changed or added relevant lines in 4 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.5%) to 97.543%
Changes Missing Coverage Covered Lines Changed/Added Lines %
exec_helpers/_ssh_client_base.py 15 16 93.75%
exec_helpers/exec_result.py 2 3 66.67%
exec_helpers/subprocess_runner.py 43 58 74.14%
Files with Coverage Reduction New Missed Lines %
exec_helpers/exec_result.py 1 98.01%
Totals Coverage Status
Change from base Build 84: -0.5%
Covered Lines: 913
Relevant Lines: 936
💛 - Coveralls

@penguinolog penguinolog added this to the 1.2.0 milestone May 2, 2018
espositocloud
espositocloud previously approved these changes May 2, 2018
View reviewed changes
@penguinolog
Fix BrokenPipeError python2.7
3837ef8 
BrokenPipeError is python3 exception inherited from OSError
with errno in (errno.EPIPE, errno.ESHUTDOWN)
espositocloud
espositocloud previously approved these changes May 2, 2018
View reviewed changes
@penguinolog penguinolog merged commit 42ebef3 into python-useful-helpers:master May 2, 2018
@penguinolog penguinolog deleted the api branch May 2, 2018 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@espositocloud espositocloud espositocloud approved these changes

@dis-xcom dis-xcom Awaiting requested review from dis-xcom dis-xcom is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@penguinolog @coveralls @espositocloud