Skip to content

Conversation

penguinolog
Copy link
Collaborator

What do these changes do?

keepalive method for context manager and keepalive_mode flag
Subprocess runner switched on import concurrent.futures like SSH.

Are there changes in behavior for the user?

ssh context manager will close connections on exit, if it enforced by keepalive_mode == False.

Related issue number

#31

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes

Subprocess runner switched on import concurrent.futures like SSH.
@penguinolog penguinolog added the enhancement New feature or request label May 4, 2018
.. versionchanged:: 1.2.1 ...
@coveralls
Copy link
Collaborator

coveralls commented May 4, 2018

Pull Request Test Coverage Report for Build 102

  • 34 of 34 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 99.688%

Totals Coverage Status
Change from base Build 99: 0.1%
Covered Lines: 957
Relevant Lines: 960

💛 - Coveralls

@penguinolog penguinolog merged commit 5931977 into python-useful-helpers:master May 4, 2018
@penguinolog penguinolog deleted the keepalive branch May 4, 2018 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants