Skip to content

Fix execute_through_host auth (not all keys the same, as Client) #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 4, 2018
Merged

Fix execute_through_host auth (not all keys the same, as Client) #33

merged 1 commit into from
May 4, 2018

Conversation

penguinolog
Copy link
Collaborator

  • Simplify code
  • adopt tests and make ordered
  • I think the code is well written
  • Unit tests for the changes exist

@penguinolog
Fix execute_through_host auth (not all keys the same, as Client)
ba6d688 
* Simplify code
* adopt tests and make ordered
@penguinolog penguinolog added bug Something isn't working enhancement New feature or request labels May 4, 2018
@coveralls
Copy link
Collaborator

coveralls commented May 4, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 104

  • 8 of 8 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.0007%) to 99.687%
Totals Coverage Status
Change from base Build 103: -0.0007%
Covered Lines: 955
Relevant Lines: 958
💛 - Coveralls

@penguinolog penguinolog merged commit 6ff0258 into python-useful-helpers:master May 4, 2018
@penguinolog penguinolog deleted the execute_through_host branch May 4, 2018 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@espositocloud espositocloud espositocloud approved these changes

@dis-xcom dis-xcom Awaiting requested review from dis-xcom dis-xcom is a code owner

Assignees
No one assigned
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@penguinolog @coveralls @espositocloud