Due to long running tests: use pytest-xdist #35
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
penguinolog
commented
May 4, 2018
penguinolog
commented
- modify tests, which can receive race-conditions
- remove never documented internal code
- add 1 test for coverage bump
* modify tests, which can receive race-conditions * remove never documented internal code * add 1 test for coverage bump
Pull Request Test Coverage Report for Build 115
💛 - Coveralls |
espositocloud
previously approved these changes
May 4, 2018
100 ms timeout & 100 ms cycle can cause false negative If stop set - all data is already read
|
old pypy3 + xdist = tests hang. use optimizations without xdist for now. |
espositocloud
approved these changes
May 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.