Skip to content

Add type stubs and py.typed. Fix #40 Fix #41 #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 18, 2018
Merged

Add type stubs and py.typed. Fix #40 Fix #41 #42

merged 2 commits into from
May 18, 2018

Conversation

penguinolog
Copy link
Collaborator

  • Signatures verified and updated
  • stubs without cyclic imports (no stubs for simple code)
  • py.typed added

@penguinolog
Add type stubs and py.typed. Fix #40 Fix #41
09ea00b 
* Signatures verified and updated
* stubs without cyclic imports (no stubs for simple code)
* py.typed added
@penguinolog penguinolog added the enhancement New feature or request label May 18, 2018
espositocloud
espositocloud reviewed May 18, 2018
View reviewed changes
doc/source/SSHClient.rst
:type verbose: ``bool``
:param timeout: Timeout for command execution.
:type timeout: ``typing.Optional[int]``
:type timeout: ``typing.Union[int, None]``
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why? I remember previously you replaced Union[x, None] with Optional

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

None is not default here, and Optional for cases, when None is default. (Anyway Optional[T] === Union[None, T])

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 126

  • 15 of 15 (100.0%) changed or added relevant lines in 6 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 123: 0.0%
Covered Lines: 933
Relevant Lines: 933
💛 - Coveralls

1 similar comment
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 126

  • 15 of 15 (100.0%) changed or added relevant lines in 6 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 123: 0.0%
Covered Lines: 933
Relevant Lines: 933
💛 - Coveralls

@coveralls
Copy link
Collaborator

coveralls commented May 18, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 126

  • 15 of 15 (100.0%) changed or added relevant lines in 6 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 123: 0.0%
Covered Lines: 933
Relevant Lines: 933
💛 - Coveralls

@penguinolog penguinolog merged commit 814d435 into python-useful-helpers:master May 18, 2018
@penguinolog penguinolog deleted the stubs_typed branch May 18, 2018 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@espositocloud espositocloud espositocloud approved these changes

@dis-xcom dis-xcom Awaiting requested review from dis-xcom dis-xcom is a code owner

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@penguinolog @coveralls @espositocloud