Skip to content

Extend ExecHelperTimeoutError Fix #43 #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 24, 2018
Merged

Extend ExecHelperTimeoutError Fix #43 #44

merged 2 commits into from
May 24, 2018

Conversation

penguinolog
Copy link
Collaborator

  • Re-subclass ExecCalledProcessError
  • Provide timeout and result
  • Add properties to access cmd, stdout_str and stderr_str

Related issue number

#43

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes

@penguinolog
Extend ExecHelperTimeoutError Fix #43
519b76b 
* Re-subclass `ExecCalledProcessError`
* Provide timeout and result
* Add properties to access cmd, stdout_str and stderr_str

Signed-off-by: Alexey Stepanov <penguinolog@gmail.com>
@penguinolog penguinolog added the enhancement New feature or request label May 24, 2018
@coveralls
Copy link
Collaborator

coveralls commented May 24, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 129

  • 17 of 17 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 127: 0.0%
Covered Lines: 945
Relevant Lines: 945
💛 - Coveralls

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 128

  • 17 of 17 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 127: 0.0%
Covered Lines: 945
Relevant Lines: 945
💛 - Coveralls

1 similar comment
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 128

  • 17 of 17 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 127: 0.0%
Covered Lines: 945
Relevant Lines: 945
💛 - Coveralls

espositocloud
espositocloud previously approved these changes May 24, 2018
View reviewed changes
@penguinolog
Pudate stub for typing
fa6d1c7 
Signed-off-by: Alexey Stepanov <penguinolog@gmail.com>
@penguinolog penguinolog merged commit eb1c3d1 into python-useful-helpers:master May 24, 2018
@penguinolog penguinolog deleted the timeout_details branch May 24, 2018 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@espositocloud espositocloud espositocloud approved these changes

@dis-xcom dis-xcom Awaiting requested review from dis-xcom dis-xcom is a code owner

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@penguinolog @coveralls @espositocloud