Skip to content

Subprocess: increase number of threads and return to blocking pipes. #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 10, 2018
Merged

Subprocess: increase number of threads and return to blocking pipes. #61

merged 1 commit into from
Aug 10, 2018

Conversation

penguinolog
Copy link
Collaborator

Found several use-cases, when non-blocking pipes can cause data loose.

In tests not checking mised stdout/stderr because of expected
race condition during log output.

  • I think the code is well written
  • Unit tests for the changes exist

rayburgemeestre
rayburgemeestre approved these changes Aug 10, 2018
View reviewed changes
Copy link

@rayburgemeestre rayburgemeestre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really like how the code is simplified now

@penguinolog penguinolog merged commit f98d3b4 into python-useful-helpers:master Aug 10, 2018
@penguinolog penguinolog deleted the subprocess_block_pipes branch August 10, 2018 12:16
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 172

  • 22 of 23 (95.65%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.1%) to 99.892%
Changes Missing Coverage Covered Lines Changed/Added Lines %
exec_helpers/subprocess_runner.py 22 23 95.65%
Totals Coverage Status
Change from base Build 170: -0.1%
Covered Lines: 924
Relevant Lines: 925
💛 - Coveralls

@penguinolog
Subprocess: increase number of threads and return to blocking pipes.
1213796 
Found several use-cases, when non-blocking pipes can cause data loose.

In tests not checking mised stdout/stderr because of expected
race condition during log output.

Signed-off-by: Alexey Stepanov <penguinolog@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dis-xcom dis-xcom Awaiting requested review from dis-xcom dis-xcom is a code owner

@espositocloud espositocloud Awaiting requested review from espositocloud

1 more reviewer

@rayburgemeestre rayburgemeestre rayburgemeestre approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@penguinolog @coveralls @rayburgemeestre