Skip to content

Old is for py27 only. Backport typehints from validated new version #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 4, 2018
Merged

Old is for py27 only. Backport typehints from validated new version #72

merged 3 commits into from
Sep 4, 2018

Conversation

penguinolog
Copy link
Collaborator

  • no *.pyi
  • no cythonize support code
  • static analysis from python 3.6 without sdist (because of mypy)

@penguinolog
Old is for py27 only. Backport typehints from validated new version
107f285 
* no *.pyi
* no cythonize support code
* static analisys from python 3.6 without sdist (because of mypy)

Signed-off-by: Alexey Stepanov <penguinolog@gmail.com>
@penguinolog penguinolog added the enhancement New feature or request label Sep 4, 2018
espositocloud
espositocloud previously approved these changes Sep 4, 2018
View reviewed changes
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 200

  • 77 of 77 (100.0%) changed or added relevant lines in 7 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.001%) to 99.894%
Totals Coverage Status
Change from base Build 187: 0.001%
Covered Lines: 946
Relevant Lines: 947
💛 - Coveralls

@coveralls
Copy link
Collaborator

coveralls commented Sep 4, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 203

  • 77 of 77 (100.0%) changed or added relevant lines in 7 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.001%) to 99.894%
Totals Coverage Status
Change from base Build 187: 0.001%
Covered Lines: 946
Relevant Lines: 947
💛 - Coveralls

@penguinolog
Remove tests, which are expected no python 2.7 compatible
da5ffcf 
Signed-off-by: Alexey Stepanov <penguinolog@gmail.com>
@penguinolog
remove useless import
d7d99a3 
Signed-off-by: Alexey Stepanov <penguinolog@gmail.com>
@penguinolog penguinolog merged commit 93fd63a into python-useful-helpers:py27 Sep 4, 2018
@penguinolog penguinolog deleted the rm_34 branch September 4, 2018 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@espositocloud espositocloud espositocloud left review comments

@dis-xcom dis-xcom Awaiting requested review from dis-xcom dis-xcom is a code owner

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@penguinolog @coveralls @espositocloud