Meta update: typing, metadata, ci requirements #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
espositocloud
previously approved these changes
Jul 17, 2018
espositocloud
approved these changes
Jul 17, 2018
* `pylint<2.0` due to not python 2.7 at pylint2 and false-negative * `mypy` target for tox (only local for now) with types declared * use `@typing.overload` for declaring return dependent from input * use `abc.ABCMeta` as metaclass for abstract code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pylint<2.0due to not python 2.7 at pylint2 and false-negativemypytarget for tox (only local for now) with types declared@typing.overloadfor declaring return dependent from inputabc.ABCMetaas metaclass for abstract code