Skip to content

Governance: code of conduct, codeowners, pull template, maintainers #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 25, 2018
Merged

Governance: code of conduct, codeowners, pull template, maintainers #2

merged 1 commit into from
Apr 25, 2018

Conversation

penguinolog
Copy link
Collaborator

  • Add typehints for protected methods

@coveralls
Copy link

coveralls commented Apr 25, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 41

  • 3 of 3 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 98.662%
Totals Coverage Status
Change from base Build 40: 0.01%
Covered Lines: 295
Relevant Lines: 299
💛 - Coveralls

espositocloud
espositocloud reviewed Apr 25, 2018
View reviewed changes
threaded/_base_gthreadpooled.py

import typing # noqa # pylint: disable=unused-import

import gevent.event # noqa # pylint: disable=unused-import
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's required for valid typecheck, but not used for the main functionality.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Used on L94

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yep, maybe next time better a dedicate commit for typing annotation?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will be done for exec-helpers

@penguinolog penguinolog merged commit 4ea2cbb into python-useful-helpers:master Apr 25, 2018
@penguinolog penguinolog deleted the governance&protected branch April 25, 2018 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@espositocloud espositocloud espositocloud approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@penguinolog @coveralls @espositocloud