Skip to content

CI Changes and expose types via overload #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 18, 2018
Merged

CI Changes and expose types via overload #21

merged 1 commit into from
Jul 18, 2018

Conversation

penguinolog
Copy link
Collaborator

  • pylint<2.0 due to python2.7 requirements
  • last mypy adoption
  • tox mypy target & expose types detail using typing.overloaded
  • Fix gevent & greenlet version for CI due to binary compatibility
    issues between them

@coveralls
Copy link

Pull Request Test Coverage Report for Build 85

  • 6 of 10 (60.0%) changed or added relevant lines in 6 files are covered.
  • 44 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-0.1%) to 98.644%
Changes Missing Coverage Covered Lines Changed/Added Lines %
threaded/_gthreadpooled2.py 0 2 0.0%
threaded/_threaded2.py 0 2 0.0%
Files with Coverage Reduction New Missed Lines %
threaded/_base_gthreadpooled.py 3 100.0%
threaded/_gthreadpooled2.py 10 100.0%
threaded/_base_threaded.py 13 97.33%
threaded/_threaded2.py 18 100.0%
Totals Coverage Status
Change from base Build 83: -0.1%
Covered Lines: 291
Relevant Lines: 295
💛 - Coveralls

1 similar comment
@coveralls
Copy link

coveralls commented Jul 18, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 85

  • 6 of 10 (60.0%) changed or added relevant lines in 6 files are covered.
  • 44 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-0.1%) to 98.644%
Changes Missing Coverage Covered Lines Changed/Added Lines %
threaded/_gthreadpooled2.py 0 2 0.0%
threaded/_threaded2.py 0 2 0.0%
Files with Coverage Reduction New Missed Lines %
threaded/_base_gthreadpooled.py 3 100.0%
threaded/_gthreadpooled2.py 10 100.0%
threaded/_base_threaded.py 13 97.33%
threaded/_threaded2.py 18 100.0%
Totals Coverage Status
Change from base Build 83: -0.1%
Covered Lines: 291
Relevant Lines: 295
💛 - Coveralls

@penguinolog penguinolog merged commit 8b1e686 into python-useful-helpers:master Jul 18, 2018
@penguinolog penguinolog deleted the typing_pylint_gevent branch July 18, 2018 14:05
@penguinolog
CI Changes and expose types via overload
a74928e 
* pylint<2.0 due to python2.7 requirements
* last mypy adoption
* tox mypy target & expose types detail using `typing.overloaded`
* Fix gevent & greenlet version for CI due to binary compatibility
  issues between them

Signed-off-by: Alexey Stepanov <penguinolog@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@espositocloud espositocloud espositocloud approved these changes

@dis-xcom dis-xcom Awaiting requested review from dis-xcom dis-xcom is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@penguinolog @coveralls @espositocloud