Skip to content

Drop python 3.4 from legacy: use new #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 5, 2018
Merged

Drop python 3.4 from legacy: use new #32

merged 4 commits into from
Sep 5, 2018

Conversation

penguinolog
Copy link
Collaborator

  • Reduce build jobs and remove cythonize code
  • backport typehints from modern code and drop pyi

@penguinolog
Drop python 3.4 from legacy: use new
81cde48 
* Reduce build jobs and remove cythonize code
* backport typehints from modern code and drop pyi

Signed-off-by: Alexey Stepanov <penguinolog@gmail.com>
@coveralls
Copy link

coveralls commented Sep 4, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 117

  • 101 of 109 (92.66%) changed or added relevant lines in 6 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-2.6%) to 95.055%
Changes Missing Coverage Covered Lines Changed/Added Lines %
threaded/_threaded.py 40 42 95.24%
threaded/_class_decorator.py 5 8 62.5%
threaded/_base_threaded.py 2 5 40.0%
Totals Coverage Status
Change from base Build 92: -2.6%
Covered Lines: 173
Relevant Lines: 182
💛 - Coveralls

@penguinolog
update README
a6d43d3 
Signed-off-by: Alexey Stepanov <penguinolog@gmail.com>
@penguinolog
cleanup tox.ini
068bc95 
Signed-off-by: Alexey Stepanov <penguinolog@gmail.com>
@penguinolog
remove cythonize code from setup.py
eb11aa1 
Signed-off-by: Alexey Stepanov <penguinolog@gmail.com>
@penguinolog penguinolog merged commit f5700e9 into python-useful-helpers:py27 Sep 5, 2018
@penguinolog penguinolog deleted the drop_34 branch September 5, 2018 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dis-xcom dis-xcom Awaiting requested review from dis-xcom dis-xcom is a code owner

@espositocloud espositocloud Awaiting requested review from espositocloud

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@penguinolog @coveralls