-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
domain validator fails for fully qualified ("absolute") domain names #124
Comments
I've recently run into this issue and actually want it to fail on those with a trailing dot. Perhaps a configurable parameter to allow us to determine how to react to such entries validators.domain('foo.com.', trailingdots=True) also consider this in URLs: validators.url('http://foo.com./content', trailingdots=True) |
As @mschiffm mentioned, the trailing dot is default allowed, so if you want to make it optional then the failing should be optional: validators.url('http://foo.com./content', trailingdots=False) |
- Uses type hints, improve docs - Regards [RFC 1035](https://www.rfc-editor.org/rfc/rfc1035) - Updates corresponding test functions - Closes python-validators#74, python-validators#81, python-validators#89, python-validators#124, python-validators#143, & python-validators#204
- Uses type hints, improve docs - Regards [RFC 1034](https://www.rfc-editor.org/rfc/rfc1034) - Updates corresponding test functions **Related items** *Issues* - Closes python-validators#52 - Closes python-validators#74 - Closes python-validators#81 - Closes python-validators#89 - Closes python-validators#95 - Closes python-validators#120 - Closes python-validators#124 - Closes python-validators#141 - Closes python-validators#143 - Closes python-validators#199 - Closes python-validators#204 *PRs* - Closes python-validators#114
- Uses type hints, improve docs - Regards [RFC 1034](https://www.rfc-editor.org/rfc/rfc1034) and [RFC 2782](https://www.rfc-editor.org/rfc/rfc2782) - Updates corresponding test functions **Related items** *Issues* - Closes python-validators#52 - Closes python-validators#74 - Closes python-validators#81 - Closes python-validators#89 - Closes python-validators#95 - Closes python-validators#120 - Closes python-validators#124 - Closes python-validators#141 - Closes python-validators#143 - Closes python-validators#199 - Closes python-validators#204 *PRs* - Closes python-validators#114 - Closes python-validators#179
- Uses type hints, improve docs - Regards [RFC 1034](https://www.rfc-editor.org/rfc/rfc1034) and [RFC 2782](https://www.rfc-editor.org/rfc/rfc2782) - Updates corresponding test functions **Related items** *Issues* - Closes python-validators#52 - Closes python-validators#74 - Closes python-validators#81 - Closes python-validators#89 - Closes python-validators#95 - Closes python-validators#120 - Closes python-validators#124 - Closes python-validators#141 - Closes python-validators#143 - Closes python-validators#199 - Closes python-validators#204 *PRs* - Closes python-validators#114 - Closes python-validators#179
Reference: https://tools.ietf.org/html/rfc1034
Discussion: http://www.dns-sd.org/trailingdotsindomainnames.html
The text was updated successfully, but these errors were encountered: