Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug, hostname with trailing dot throws exception #204

Closed
plejon opened this issue Mar 10, 2022 · 2 comments · Fixed by #231
Closed

Bug, hostname with trailing dot throws exception #204

plejon opened this issue Mar 10, 2022 · 2 comments · Fixed by #231
Labels
duplicate Issue/PR: Redundant

Comments

@plejon
Copy link

plejon commented Mar 10, 2022

Throws error when hostnames has trailing dot.
Example usage is for pushing records to Azure DNS.

import validators
validators.domain('example.com.')
ValidationFailure(func=domain, args={'value': 'example.com.'})
validators.__version__
'0.18.2'
@paulmillar
Copy link

Just to mention, a web page dedicated to trailing dots in domain name. There is also this related Stack Overflow question. Both make it clear that a URL, where the authority part has a FQDN with a final dot, is a valid URL.

@yozachar yozachar added the duplicate Issue/PR: Redundant label Mar 2, 2023
@yozachar
Copy link
Collaborator

yozachar commented Mar 2, 2023

duplicate of #124

yozachar added a commit to yozachar/pyvalidators that referenced this issue Mar 2, 2023
yozachar added a commit to yozachar/pyvalidators that referenced this issue Mar 2, 2023
- Uses type hints, improve docs
- Regards [RFC 1034](https://www.rfc-editor.org/rfc/rfc1034)
- Updates corresponding test functions

**Related items**

*Issues*

- Closes python-validators#52
- Closes python-validators#74
- Closes python-validators#81
- Closes python-validators#89
- Closes python-validators#95
- Closes python-validators#120
- Closes python-validators#124
- Closes python-validators#141
- Closes python-validators#143
- Closes python-validators#199
- Closes python-validators#204

*PRs*

- Closes python-validators#114
yozachar added a commit to yozachar/pyvalidators that referenced this issue Mar 2, 2023
- Uses type hints, improve docs
- Regards [RFC 1034](https://www.rfc-editor.org/rfc/rfc1034) and [RFC 2782](https://www.rfc-editor.org/rfc/rfc2782)
- Updates corresponding test functions

**Related items**

*Issues*

- Closes python-validators#52
- Closes python-validators#74
- Closes python-validators#81
- Closes python-validators#89
- Closes python-validators#95
- Closes python-validators#120
- Closes python-validators#124
- Closes python-validators#141
- Closes python-validators#143
- Closes python-validators#199
- Closes python-validators#204

*PRs*

- Closes python-validators#114
- Closes python-validators#179
yozachar added a commit to yozachar/pyvalidators that referenced this issue Mar 2, 2023
- Uses type hints, improve docs
- Regards [RFC 1034](https://www.rfc-editor.org/rfc/rfc1034) and [RFC 2782](https://www.rfc-editor.org/rfc/rfc2782)
- Updates corresponding test functions

**Related items**

*Issues*

- Closes python-validators#52
- Closes python-validators#74
- Closes python-validators#81
- Closes python-validators#89
- Closes python-validators#95
- Closes python-validators#120
- Closes python-validators#124
- Closes python-validators#141
- Closes python-validators#143
- Closes python-validators#199
- Closes python-validators#204

*PRs*

- Closes python-validators#114
- Closes python-validators#179
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate Issue/PR: Redundant
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants