-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ValidationFailure on real domains with accent characters #74
Comments
PRs welcome! |
I'll give it a try, time to play regex gold I guess. I noticed it also trips up on valid Chinese domain names. In Latin charsets these are basically domain names and TLDs that start with |
Domains like аренда.орг and मुम्बई.संगठन are valid. (disclaimer, i have not looked up the translations of these words, they might be something horrible :)) Here you'll find some more nice tld's: https://namestat.org/xn--i1b6b1a6a2e |
- Uses type hints, improve docs - Regards [RFC 1035](https://www.rfc-editor.org/rfc/rfc1035) - Updates corresponding test functions - Closes python-validators#74, python-validators#81, python-validators#89, python-validators#124, python-validators#143, & python-validators#204
- Uses type hints, improve docs - Regards [RFC 1034](https://www.rfc-editor.org/rfc/rfc1034) - Updates corresponding test functions **Related items** *Issues* - Closes python-validators#52 - Closes python-validators#74 - Closes python-validators#81 - Closes python-validators#89 - Closes python-validators#95 - Closes python-validators#120 - Closes python-validators#124 - Closes python-validators#141 - Closes python-validators#143 - Closes python-validators#199 - Closes python-validators#204 *PRs* - Closes python-validators#114
- Uses type hints, improve docs - Regards [RFC 1034](https://www.rfc-editor.org/rfc/rfc1034) and [RFC 2782](https://www.rfc-editor.org/rfc/rfc2782) - Updates corresponding test functions **Related items** *Issues* - Closes python-validators#52 - Closes python-validators#74 - Closes python-validators#81 - Closes python-validators#89 - Closes python-validators#95 - Closes python-validators#120 - Closes python-validators#124 - Closes python-validators#141 - Closes python-validators#143 - Closes python-validators#199 - Closes python-validators#204 *PRs* - Closes python-validators#114 - Closes python-validators#179
- Uses type hints, improve docs - Regards [RFC 1034](https://www.rfc-editor.org/rfc/rfc1034) and [RFC 2782](https://www.rfc-editor.org/rfc/rfc2782) - Updates corresponding test functions **Related items** *Issues* - Closes python-validators#52 - Closes python-validators#74 - Closes python-validators#81 - Closes python-validators#89 - Closes python-validators#95 - Closes python-validators#120 - Closes python-validators#124 - Closes python-validators#141 - Closes python-validators#143 - Closes python-validators#199 - Closes python-validators#204 *PRs* - Closes python-validators#114 - Closes python-validators#179
I have a know legit domain that contains the German accent
ä
. This domain is registered, public whois record etc.Running it through
validators.domain(target)
returns aValidationError
.Apparently such domains are valid since 2003: https://www.iis.se/english/domains/se/idn/
The text was updated successfully, but these errors were encountered: