Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ValidationFailure on real domains with accent characters #74

Closed
serain opened this issue Jan 21, 2018 · 3 comments · Fixed by #231
Closed

ValidationFailure on real domains with accent characters #74

serain opened this issue Jan 21, 2018 · 3 comments · Fixed by #231
Labels
bug Issue: Works not as designed

Comments

@serain
Copy link

serain commented Jan 21, 2018

I have a know legit domain that contains the German accent ä. This domain is registered, public whois record etc.

Running it through validators.domain(target) returns a ValidationError.

Apparently such domains are valid since 2003: https://www.iis.se/english/domains/se/idn/

@kvesteri
Copy link
Collaborator

PRs welcome!

@serain
Copy link
Author

serain commented Mar 21, 2018

I'll give it a try, time to play regex gold I guess. I noticed it also trips up on valid Chinese domain names. In Latin charsets these are basically domain names and TLDs that start with xn--.

@stitch
Copy link

stitch commented Apr 30, 2019

Domains like аренда.орг and मुम्बई.संगठन are valid. (disclaimer, i have not looked up the translations of these words, they might be something horrible :))

Here you'll find some more nice tld's: https://namestat.org/xn--i1b6b1a6a2e

@yozachar yozachar added the bug Issue: Works not as designed label Mar 2, 2023
yozachar added a commit to yozachar/pyvalidators that referenced this issue Mar 2, 2023
yozachar added a commit to yozachar/pyvalidators that referenced this issue Mar 2, 2023
- Uses type hints, improve docs
- Regards [RFC 1034](https://www.rfc-editor.org/rfc/rfc1034)
- Updates corresponding test functions

**Related items**

*Issues*

- Closes python-validators#52
- Closes python-validators#74
- Closes python-validators#81
- Closes python-validators#89
- Closes python-validators#95
- Closes python-validators#120
- Closes python-validators#124
- Closes python-validators#141
- Closes python-validators#143
- Closes python-validators#199
- Closes python-validators#204

*PRs*

- Closes python-validators#114
yozachar added a commit to yozachar/pyvalidators that referenced this issue Mar 2, 2023
- Uses type hints, improve docs
- Regards [RFC 1034](https://www.rfc-editor.org/rfc/rfc1034) and [RFC 2782](https://www.rfc-editor.org/rfc/rfc2782)
- Updates corresponding test functions

**Related items**

*Issues*

- Closes python-validators#52
- Closes python-validators#74
- Closes python-validators#81
- Closes python-validators#89
- Closes python-validators#95
- Closes python-validators#120
- Closes python-validators#124
- Closes python-validators#141
- Closes python-validators#143
- Closes python-validators#199
- Closes python-validators#204

*PRs*

- Closes python-validators#114
- Closes python-validators#179
yozachar added a commit to yozachar/pyvalidators that referenced this issue Mar 2, 2023
- Uses type hints, improve docs
- Regards [RFC 1034](https://www.rfc-editor.org/rfc/rfc1034) and [RFC 2782](https://www.rfc-editor.org/rfc/rfc2782)
- Updates corresponding test functions

**Related items**

*Issues*

- Closes python-validators#52
- Closes python-validators#74
- Closes python-validators#81
- Closes python-validators#89
- Closes python-validators#95
- Closes python-validators#120
- Closes python-validators#124
- Closes python-validators#141
- Closes python-validators#143
- Closes python-validators#199
- Closes python-validators#204

*PRs*

- Closes python-validators#114
- Closes python-validators#179
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue: Works not as designed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants