-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Domain not handle None object #143
Comments
Of course, I can check it before using the validators, but the validator already checks it, so why not to handle the "None" case? |
a solution may be in the catch statement:
|
Open new PR: |
I looked at other validators (not only the domain) and it seems that all of them don't handling the "None" as input... |
- Uses type hints, improve docs - Regards [RFC 1035](https://www.rfc-editor.org/rfc/rfc1035) - Updates corresponding test functions - Closes python-validators#74, python-validators#81, python-validators#89, python-validators#124, python-validators#143, & python-validators#204
- Uses type hints, improve docs - Regards [RFC 1034](https://www.rfc-editor.org/rfc/rfc1034) - Updates corresponding test functions **Related items** *Issues* - Closes python-validators#52 - Closes python-validators#74 - Closes python-validators#81 - Closes python-validators#89 - Closes python-validators#95 - Closes python-validators#120 - Closes python-validators#124 - Closes python-validators#141 - Closes python-validators#143 - Closes python-validators#199 - Closes python-validators#204 *PRs* - Closes python-validators#114
- Uses type hints, improve docs - Regards [RFC 1034](https://www.rfc-editor.org/rfc/rfc1034) and [RFC 2782](https://www.rfc-editor.org/rfc/rfc2782) - Updates corresponding test functions **Related items** *Issues* - Closes python-validators#52 - Closes python-validators#74 - Closes python-validators#81 - Closes python-validators#89 - Closes python-validators#95 - Closes python-validators#120 - Closes python-validators#124 - Closes python-validators#141 - Closes python-validators#143 - Closes python-validators#199 - Closes python-validators#204 *PRs* - Closes python-validators#114 - Closes python-validators#179
- Uses type hints, improve docs - Regards [RFC 1034](https://www.rfc-editor.org/rfc/rfc1034) and [RFC 2782](https://www.rfc-editor.org/rfc/rfc2782) - Updates corresponding test functions **Related items** *Issues* - Closes python-validators#52 - Closes python-validators#74 - Closes python-validators#81 - Closes python-validators#89 - Closes python-validators#95 - Closes python-validators#120 - Closes python-validators#124 - Closes python-validators#141 - Closes python-validators#143 - Closes python-validators#199 - Closes python-validators#204 *PRs* - Closes python-validators#114 - Closes python-validators#179
- Uses type hints, improve docs - Regards [RFC 1034](https://www.rfc-editor.org/rfc/rfc1034) and [RFC 2782](https://www.rfc-editor.org/rfc/rfc2782) - Updates corresponding test functions **Related items** *Issues* - Closes python-validators#52 - Closes python-validators#74 - Closes python-validators#81 - Closes python-validators#89 - Closes python-validators#95 - Closes python-validators#120 - Closes python-validators#124 - Closes python-validators#141 - Closes python-validators#143 - Closes python-validators#199 - Closes python-validators#204 *PRs* - Closes python-validators#114 - Closes python-validators#179
validators None issue:
code:
error
The text was updated successfully, but these errors were encountered: