-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
valid domain return an invalid error #95
Labels
bug
Issue: Works not as designed
Comments
I have the same problem. I use this module to parse domains from ads/malware delivery lists and indeed a of lot of them contain just a digit between two dots:
|
marmeladema
added a commit
to marmeladema/validators
that referenced
this issue
Feb 24, 2019
Dan-at-Extrahop
added a commit
to ExtraHop/threat-intelligence-toolkit
that referenced
this issue
Mar 29, 2019
validators library issues: - python-validators/validators#116 - python-validators/validators#95
yozachar
added a commit
to yozachar/pyvalidators
that referenced
this issue
Mar 2, 2023
- Uses type hints, improve docs - Regards [RFC 1034](https://www.rfc-editor.org/rfc/rfc1034) - Updates corresponding test functions **Related items** *Issues* - Closes python-validators#52 - Closes python-validators#74 - Closes python-validators#81 - Closes python-validators#89 - Closes python-validators#95 - Closes python-validators#120 - Closes python-validators#124 - Closes python-validators#141 - Closes python-validators#143 - Closes python-validators#199 - Closes python-validators#204 *PRs* - Closes python-validators#114
yozachar
added a commit
to yozachar/pyvalidators
that referenced
this issue
Mar 2, 2023
- Uses type hints, improve docs - Regards [RFC 1034](https://www.rfc-editor.org/rfc/rfc1034) and [RFC 2782](https://www.rfc-editor.org/rfc/rfc2782) - Updates corresponding test functions **Related items** *Issues* - Closes python-validators#52 - Closes python-validators#74 - Closes python-validators#81 - Closes python-validators#89 - Closes python-validators#95 - Closes python-validators#120 - Closes python-validators#124 - Closes python-validators#141 - Closes python-validators#143 - Closes python-validators#199 - Closes python-validators#204 *PRs* - Closes python-validators#114 - Closes python-validators#179
yozachar
added a commit
to yozachar/pyvalidators
that referenced
this issue
Mar 2, 2023
- Uses type hints, improve docs - Regards [RFC 1034](https://www.rfc-editor.org/rfc/rfc1034) and [RFC 2782](https://www.rfc-editor.org/rfc/rfc2782) - Updates corresponding test functions **Related items** *Issues* - Closes python-validators#52 - Closes python-validators#74 - Closes python-validators#81 - Closes python-validators#89 - Closes python-validators#95 - Closes python-validators#120 - Closes python-validators#124 - Closes python-validators#141 - Closes python-validators#143 - Closes python-validators#199 - Closes python-validators#204 *PRs* - Closes python-validators#114 - Closes python-validators#179
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Inputting a valid domain name "ktbooks.1.v77.faidns.com", I received a invalid domain error. A domain name can include only one digit between 2 dots. So the pattern could be changed like this:
pattern = re.compile(
r'^(:?(([a-zA-Z0-9]{1})|([a-zA-Z]{1}[a-zA-Z]{1})|' # domain pt.1
r'([a-zA-Z]{1}[0-9]{1})|([0-9]{1}[a-zA-Z]{1})|' # domain pt.2
r'([a-zA-Z0-9][-_a-zA-Z0-9]{0,61}[a-zA-Z0-9])).)+' # domain pt.3
r'([a-zA-Z]{2,13}|(xn--[a-zA-Z0-9]{2,30}))$' # TLD
)
The text was updated successfully, but these errors were encountered: