Fix test failures with latest branca #1556
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM but I would I'll leave this here for @Conengmo to take a second look. He has been the main folium maintainer for a while now and know way more than I do about the current tests. |
|
Thanks @oefe for the fix! |
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bianca removed uuid4 recently for performance reasons.
Rather than trying to mock what branch is using now to generate IDs, I think it's better not to mock id generation at all. This required a few changes on how to test the result of
to_dict.I wonder, though, wether we really should compare for equality. This will break again whenever branca adds new values to the dict, or changes internals. Maybe it would be better to just assert on specific keys that we are interested in, or not check
to_dictat all?