Skip to content

Multiple instances of TimeSliderChoropleth on a single map #1749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
May 17, 2023
Merged

Multiple instances of TimeSliderChoropleth on a single map #1749

merged 6 commits into from
May 17, 2023

Conversation

Conengmo
Copy link
Member

@Conengmo Conengmo commented Apr 8, 2023

Closes #1744.

Allow multiple instances of TimeSliderChoropleth on a single map.

  • I used a code block to limit the scope of the the variables and functions used, except for the GeoJson object that will also be added to LayerControl.
  • Give every CSS id a unique id.
  • Show and hide the slider together with the layer.
  • Restore the broken highlight functionality.

@Conengmo Conengmo mentioned this pull request Apr 8, 2023
Closed
@Conengmo
Copy link
Member Author

Rest of the test failures is unrelated, so I'll go ahead and merge this one, since a user confirmed this works for them.

@Conengmo Conengmo merged commit 4431da8 into python-visualization:main May 17, 2023
@Conengmo Conengmo deleted the multiple-timeslider-choropleths branch May 17, 2023 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

multiple TimeSliderChoropleth fails
1 participant
@Conengmo