logs overwhelmed by Failing the WebSocket connection: 1006

[messense]

Seeing this a lot in logs when closing a websocket connection.

Code 1006 seems caused by readexactly hitting EOF, which seems fine when closing websocket connection.

[RemiCardona]

could you try the patch in PR #127 ? This should reduce the severity of messages in this very case.

[JCharante]

#127 was just recently merged into master. Is your issue still occurring @messense?

[messense]

Fixed, thanks.

[messense]

Oh, still occurring

2017-03-29 11:33:57,429 INFO websockets.protocol.fail_connection:613   Failing the WebSocket connection: 1006

[JCharante]

Did you update via pip/pypi? It still has v3.2, all the way from August.

I'll download the master branch and see if I can reproduce it.

[messense]

I am using the master branch.

pip install -U https://github.com/aaugustin/websockets/archive/master.zip

[JCharante]

I didn't know you could do that with pip, Neat.

What do you run to test it out?

[messense]

The code I am running in production is in here:

https://github.com/bosondata/chrome-prerender/blob/master/prerender/chromerdp.py#L86

[RemiCardona]

Do you have a full backtrace ? What kind of websocket server are you connecting to ?

Thanks

[aaugustin]

FWIW I released 3.3 today.

It includes the latest changes related to the issue discussed here.

Testing with that version may make it easier to confirm we're all talking about the same version of the code.

[messense]

The latest version still occurring.

@RemiCardona I am connecting to Chrome remote debugger.

[messense]

The problem is that it is always logged in here:

https://github.com/aaugustin/websockets/blob/master/websockets/protocol.py#L618