Skip to content

Fix IP changes being missed by ServiceInfo #1102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Oct 31, 2022
Merged

Fix IP changes being missed by ServiceInfo #1102

merged 14 commits into from
Oct 31, 2022

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Oct 31, 2022

We previously assumed we should only update the address when the server changed, but we need to handle ip changes.

Related issue home-assistant/core#80211

@codecov-commenter
Copy link

codecov-commenter commented Oct 31, 2022

Codecov Report

Merging #1102 (4c5ffd7) into master (aee3165) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 4c5ffd7 differs from pull request most recent head 28424fb. Consider uploading reports for the commit 28424fb to get more accurate results

@@           Coverage Diff           @@
##           master    #1102   +/-   ##
=======================================
  Coverage   99.91%   99.91%           
=======================================
  Files          21       21           
  Lines        2459     2463    +4     
  Branches      442      442           
=======================================
+ Hits         2457     2461    +4     
  Partials        2        2           
Impacted Files Coverage Δ
zeroconf/_services/info.py 99.61% <100.00%> (+<0.01%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@bdraco bdraco changed the title WIP: Debug ip change Fix IP changes being missed Oct 31, 2022
@bdraco bdraco marked this pull request as ready for review October 31, 2022 16:41
@bdraco bdraco changed the title Fix IP changes being missed Fix IP changes being missed by ServiceInfo Oct 31, 2022
@bdraco bdraco merged commit 524ae89 into master Oct 31, 2022
@bdraco bdraco deleted the ip_change_fix branch October 31, 2022 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants