(Closes #285) Removed assumption that interface indexes must have IPv6 addresses. #286
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…loses python-zeroconf#285) In __init__, not all addresses assigned to interface indicies were being checked to determine ip_version. In interface_index_to_ip6_address, Runtime error is thrown if there is no IPv6 address, even if v4 address is present.
Returning ("", 0, 0) instead of None to maintain typing.
Uncertain if this will cover case where interface index of v4_only device is provided.
Using ifaddr.get_adapters to get the index and pass to zeroconf's init.
adapters object given by ifaddr does not support index. It is now converted to a list prior to index access.
Returning ("", 0, 0) instead of None to maintain typing.
Added test to check v4_only case
Uncertain if this will cover case where interface index of v4_only device is provided.
Added test for interface indices instead of address
Using ifaddr.get_adapters to get the index and pass to zeroconf's init.
Fixed index error in test_interface_index
adapters object given by ifaddr does not support index. It is now converted to a list prior to index access.
Removed Test pulling from ifaddr adapters, causes issues with protocol
Removed commented out breakpoint statement
Removed extraneous import of ifaddr in tests
|
@VishSwami Can you rebase this on |
|
I'm closing this as its gone stale. Please open a fresh PR if you are still interested in pursuing this change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In init, not all addresses assigned to interface indices were being checked to determine ip_version. In interface_index_to_ip6_address, Runtime error is thrown if there is no IPv6 address, even if v4 address is present.