Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add python 3.7 to CI and bump ZK versions to latests #574

Merged
merged 8 commits into from
Oct 9, 2019
Merged

Add python 3.7 to CI and bump ZK versions to latests #574

merged 8 commits into from
Oct 9, 2019

Conversation

StephenSorriaux
Copy link
Member

Fixes #552

jeffwidman
jeffwidman previously approved these changes Oct 8, 2019
View reviewed changes
Copy link
Member

@jeffwidman jeffwidman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thanks for the hard work here!

I would not be opposed to dropping zookeeper 3.3 (#575) and python 3.{4-6} (#576) from the tox/travis test matrices.

Given that you're working on this now, it might be an ideal time to handle that while you're brain/testing is going on.

jeffwidman
jeffwidman approved these changes Oct 9, 2019
View reviewed changes
Copy link
Member

@jeffwidman jeffwidman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great.

Two travis failures due to flaky network connectivity, so I kickstarted them again.

Once they go green, then go ahead and merge this.

@jeffwidman
Copy link
Member

Fix #575 and #576

@StephenSorriaux
Copy link
Member Author

Thanks Jeff!

@StephenSorriaux StephenSorriaux merged commit c293aab into master Oct 9, 2019
@bbangert bbangert deleted the feat/python-37 branch October 9, 2019 18:14
This was referenced Oct 9, 2019
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeffwidman jeffwidman jeffwidman approved these changes

@bbangert bbangert Awaiting requested review from bbangert

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Adding Python 3.7 support
2 participants
@StephenSorriaux @jeffwidman