This repository was archived by the owner on Nov 23, 2017. It is now read-only.
Make Tasks check if Futures are attached to the same event loop #303
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, but let's wait until the OP gives it a thumbs-up. Thanks for the quick fix! |
|
It's fine with me, thanks! |
|
BTW, there is no way to do the check if the future already has the result. So the exception will only be raised for futures without results/exceptions set. |
|
That's OK, those futures are harmless. Go ahead and merge. --Guido (mobile)
|
|
Merged. Thanks! |
akheron
pushed a commit
to akheron/cpython
that referenced
this pull request
Dec 12, 2015
See python/asyncio#303 for details --HG-- branch : 3.4
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.