This repository was archived by the owner on Nov 23, 2017. It is now read-only.
loop.getaddrinfo accepts service names like "http" for port. #354
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes #353 . |
| port = int(port) | ||
| except ValueError: | ||
| # Might be a service name like "http". | ||
| port = socket.getservbyname(port) |
There was a problem hiding this comment.
This works only when port is an str, right? How does the port=b'http' test pass?
There was a problem hiding this comment.
Ah, I see. But why don't we just convert bytes to str?
socket.getaddrinfo('127.0.0.1', b'http') works so should our code.
ajdavis
force-pushed
the
getaddrinfo-servname
branch
from
f721972 to
3ba5348
Compare
| @@ -104,8 +104,18 @@ def _ipaddr_info(host, port, family, type, proto): | |||
|
|
|||
| if port in {None, '', b''}: | |||
There was a problem hiding this comment.
While you're here, could you please fix a BytesWarning:
Please replace if port in {None, '', b''}: with if port is None:;
add if port == '': port = 0 else: to the elif isinstance(port, str),
do the same for bytes.
|
Merged by hand in 2959a97 Thanks a lot, Jesse. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
loop.getaddrinfo accepts service names like "http" for port.