This repository was archived by the owner on Nov 23, 2017. It is now read-only.
Use socket specs for getaddrinfo() in sock_connect() #365
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In BaseSelectorEventLoop.sock_connect(), an address is resolved if needed, but getaddrinfo() isn't called with the socket's parameters (family, proto, etc). If the resolved address mismatch the socket type, the connection fails. For instance, if getaddrinfo() returns an IPv6 (AF_INET6) resolution and the socket is an AF_INET, sock_connect() eventually raises a TypeError.
|
LGTM, thanks. |
|
LGTM |
|
Thanks a lot! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
BaseSelectorEventLoop.sock_connect(), an address is resolved if needed, butgetaddrinfo()isn't called with the socket's parameters (family, proto, etc).If the resolved address mismatch the socket type, the connection fails.
For instance, if
getaddrinfo()returns an IPv6 (AF_INET6) resolution and thesocket is of family
AF_INET,sock_connect()eventually raises aTypeError.This PR is a follow-up to #357.