-
-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the branch number to cherry pick commits? #44
Comments
From @ncoghlan on March 12, 2017 9:44 The other interesting question here is whether or not to leave the original PR number in the commit summary (if it's present). If we do, it has the nice property of automatically mentioning the backport PR on the original PR page. |
Perhaps this can be discussed in the core-workflow repo :) (Once I figured out how to move the script there) |
So I imported the script to core-workflow (not sure if I did it correctly or not..) Please re-create these issues there :) |
Addressed in #68 |
…H-68) * Added--abort and --continue options * Added --status option, it will do git status in the CPython dir * Automatically prefix the commit title with [X.Y] * Automatically replace #<PR-ID> with GH-<PR-ID> * Wrote some more tests Closes python/core-workflow#44 Closes python/core-workflow#45
From @ncoghlan on March 12, 2017 4:46
I like having the '[X.Y]' prefixes in cherry pick commit messages, so I went exploring to figure out how we could add them automatically here.
As far as I can tell, the best available option seems to be a combination of
git commit --amend -m
and http://stackoverflow.com/questions/7293008/how-to-read-last-commit-comment which would involve doing:to get the full text of the current commit message, prepending the appropriate "[X.Y] " header, and then writing it back into the cherry-pick commit with
git commit --amend -m
.Is that a change you might be interested in including if I put together a PR?
Copied from original issue: Mariatta/chic_a_cherry_picker#14
The text was updated successfully, but these errors were encountered: